Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @tcelestino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the dotfiles repository by introducing separate, OS-specific installation scripts for Linux and macOS. It also enhances documentation by listing common applications and development tools used on each platform, and refines existing Git and Zsh configurations for better usability and consistency across environments.
Highlights
- OS-Specific Installation Scripts: Introduced dedicated
installscripts for Linux and macOS, streamlining the setup process for each operating system. The Linux script is comprehensive, handling zsh, oh-my-zsh, Homebrew, Deno, Git, Zsh settings, Homebrew packages (via Brewfile), NPM, and fonts, with interactive prompts. The macOS script is currently a stub with helper functions. - Enhanced Documentation for Apps and Tools: Added new markdown files (
docs/dev-tools.md,docs/linux-apps.md,docs/macos-apps.md) to comprehensively list development tools, Linux-specific applications, and macOS-specific applications, including a detailed list of Raycast extensions. - Refined Git Configuration: Updated
.gitconfigto include a new commit message template (.git-commit-template), setcore.editorto$EDITOR, enablepush.autoSetupRemote, and standardize branch names in aliases (e.g.,devtodevelop). - Updated Zsh Configuration and Aliases: Introduced a new Linux-specific
.zshrcwith detailed environment variables and updated aliases for consistency and modern commands (e.g.,python -m SimpleHTTPServertopython3 -m http.server). A newworkFolderfunction was added tocustom-functions.plugin.zshfor easier navigation to common work directories. - Terminal Configuration Changes: Added a new Ghostty terminal configuration for macOS (
macos/.ghostty-config) and removed the old iTerm2 Dracula theme file (iterm2/Dracula.itermcolors), indicating a shift in preferred terminal setup.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the dotfiles repository by separating configurations for Linux and macOS, which is a great improvement for maintainability. The changes include updated documentation, new installation scripts for each OS, and refined configurations.
My review focuses on ensuring the new installation scripts are correct and robust. I've found several critical issues in the linux/install script related to incorrect file paths that will cause the installation to fail. The macos/install script appears to be incomplete. Additionally, there are a few other high-severity issues in the configuration files that could lead to errors, and some medium-severity issues in the documentation.
Please review the detailed comments for specific suggestions on how to fix these issues.
94810c7 to
4cd4118
Compare
f2e6a60 to
84f10e5
Compare
Changelog
Issue: #(issue)
Checklist
Choose the appropriate options:
How to test
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.