Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tcelestino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents a significant pivot in the dotfiles repository's focus, moving from a macOS-centric setup to one primarily optimized for Linux environments. The changes streamline the installation process, remove platform-specific dependencies, and enhance core development tool configurations for a more consistent and user-friendly experience on Linux.
Highlights
- Operating System Focus Shift: The dotfiles repository has been re-oriented from a dual macOS/Ubuntu setup to primarily focus on Linux (Ubuntu). This involved the removal of all macOS-specific configuration files (e.g.,
.macos, iTerm2 settings), Homebrew Casks, and related aliases. - Enhanced and Interactive Installation Script: The
installscript has been significantly refactored to provide a more robust and interactive user experience. It now prompts the user to confirm each major installation and configuration step (e.g., Zsh, Homebrew, Deno, Git, NPM, Fonts), allowing for selective setup and providing clear feedback on completed actions. - Git Configuration Standardization: A new standard Git commit message template (
.git-commit-template) has been introduced and configured for use. Additionally, Git aliases have been updated for consistency, and thecore.editorsetting now respects the$EDITORenvironment variable. - Zsh Environment Refinement: Zsh plugins have been streamlined by removing macOS-specific ones. Aliases were updated for better Linux compatibility, and a new
workFolderfunction was added to simplify navigation to common development directories, improving cross-platform usability for core dotfiles.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the dotfiles to be more focused on a Linux environment, removing macOS-specific configurations. The install script has been significantly improved, now featuring interactive steps and better error handling, which is a great enhancement for usability. I've identified a couple of bugs: one in the install script that would prevent fonts from being installed correctly, and another in an alias definition in zsh/aliases.zsh. Overall, these are great changes that make your dotfiles more modular and user-friendly for a Linux setup. Addressing the issues I've pointed out will ensure everything works as expected.
| if [ ! -d "$font_dir" ]; then | ||
| mkdir -p "$font_dir" | ||
| fi | ||
| copy_dir "$DIR/extras/fonts" "$font_dir" |
There was a problem hiding this comment.
The copy_dir function copies the source directory itself, not its contents. This will result in the fonts being installed to ~/.local/share/fonts/extras/fonts instead of ~/.local/share/fonts/, which is likely not the intended behavior. Additionally, the log message is currently placed before the copy operation, but it's not being used in the code suggestion. It's better practice to log what you're about to do before you do it.
cp -r "$DIR/extras/fonts/. " "$font_dir"
| alias fs="stat -f \"%z bytes\"" | ||
| alias chmox='chmod -x' | ||
| # utils | ||
| alias fs="stat -c "%s bytes"" |
There was a problem hiding this comment.
The fs alias has unescaped double quotes within the alias definition, which will cause it to be parsed incorrectly by the shell. To fix this, you can use single quotes for the alias definition.
alias fs='stat -c "%s bytes"'
| log "Installing oh-my-zsh..." | ||
|
|
||
| # Download the install script to a temporary file | ||
| local temp_script=$(mktemp) |
There was a problem hiding this comment.
The oh-my-zsh installer should be run in unattended mode to avoid requiring user interaction during the installation process. Add the --unattended flag to the install script.
if ! bash "$temp_script" --unattended; then
1 participant
Changelog
Issue: #(issue)
Checklist
Choose the appropriate options:
How to test
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.