Temporal: Tests related to disallowing units smaller than months in PlainYearMonth addition #4883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
temporal-3253
branch
2 times, most recently
from
9809507 to
369c8a9
Compare
Ms2ger
approved these changes
Jan 26, 2026
Durations with units lower than months are no longer allowed. (The lower units may be present but 0.) Adjust the existing PlainYearMonth addition tests to test this behaviour and delete tests that are now irrelevant. Normative change: tc39/proposal-temporal#3253 Approved in 2026-01 TC39 plenary.
I had previously postponed adding these tests because they were affected by tc39/proposal-temporal#3197. Now that TC39 has adopted a solution to that bug, we can add these and increase test coverage for non-ISO8601 calendar addition in PlainYearMonth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TC39 adopted a normative change (tc39/proposal-temporal#3253) which disallows adding/subtracting units smaller than months to a Temporal.PlainYearMonth, and at the same time fixes a bug when subtracting with
{ overflow: 'reject' }. This PR adds tests ensuring that the removed functionality is no longer present, as well as some Intl Era/Month Code tests that were previously not committed because they'd have been affected by the bug.See: tc39/proposal-temporal#3253