Added coverage for abrupt completion where ToString throws because of getter #4875
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 19, 2026
ljharb
force-pushed
the
error-getter-name-message0116
branch
from
c32bca1 to
a677718
Compare
ptomato
force-pushed
the
error-getter-name-message0116
branch
from
a677718 to
e0a06a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This PR adds test cases to verify that Error.prototype.toString() correctly handles abrupt completions during property lookups, as defined in Error.prototype.toString.
Specifically, it covers:
I have implemented these cases by using objects with getters that throw a Test262Error. Since both cases share a similar logic, I have included them in a single test file for clarity.