Skip to content

harness: Remove typeCoercion.js BigInt/Symbol dependencies #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gibson042 merged 1 commit into from
Nov 19, 2025
Merged

harness: Remove typeCoercion.js BigInt/Symbol dependencies #4683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion harness/features.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
atomicsHelper: [Atomics]
typeCoercion.js: [Symbol.toPrimitive, BigInt]
testAtomics.js: [ArrayBuffer, Atomics, DataView, SharedArrayBuffer, Symbol, TypedArray]
testBigIntTypedArray.js: [BigInt, TypedArray]
testTypedArray.js: [TypedArray]
Expand Down
70 changes: 44 additions & 26 deletions harness/typeCoercion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ function testPrimitiveWrappers(primitiveValue, hint, test) {
}

function testCoercibleToPrimitiveWithMethod(hint, method, test) {
var supportsToPrimitive = typeof Symbol !== "undefined" && !!Symbol.toPrimitive;

var methodNames;
if (hint === "number") {
methodNames = ["valueOf", "toString"];
Expand All @@ -158,11 +160,13 @@ function testCoercibleToPrimitiveWithMethod(hint, method, test) {
throw new Test262Error();
}
// precedence order
test({
[Symbol.toPrimitive]: method,
[methodNames[0]]: function() { throw new Test262Error(); },
[methodNames[1]]: function() { throw new Test262Error(); },
});
if (supportsToPrimitive) {
test({
[Symbol.toPrimitive]: method,
[methodNames[0]]: function() { throw new Test262Error(); },
[methodNames[1]]: function() { throw new Test262Error(); },
});
}
test({
[methodNames[0]]: method,
[methodNames[1]]: function() { throw new Test262Error(); },
Expand All @@ -178,16 +182,18 @@ function testCoercibleToPrimitiveWithMethod(hint, method, test) {
}

// GetMethod: if func is undefined or null, return undefined.
test({
[Symbol.toPrimitive]: undefined,
[methodNames[0]]: method,
[methodNames[1]]: method,
});
test({
[Symbol.toPrimitive]: null,
[methodNames[0]]: method,
[methodNames[1]]: method,
});
if (supportsToPrimitive) {
test({
[Symbol.toPrimitive]: undefined,
[methodNames[0]]: method,
[methodNames[1]]: method,
});
test({
[Symbol.toPrimitive]: null,
[methodNames[0]]: method,
[methodNames[1]]: method,
});
}

// if methodNames[0] is not callable, fallback to methodNames[1]
test({
Expand Down Expand Up @@ -253,7 +259,9 @@ function testNotCoercibleToNumber(test) {
}

// ToNumber: Symbol -> TypeError
testPrimitiveValue(Symbol("1"));
if (typeof Symbol !== "undefined") {
testPrimitiveValue(Symbol("1"));
}

if (typeof BigInt !== "undefined") {
// ToNumber: BigInt -> TypeError
Expand All @@ -265,18 +273,22 @@ function testNotCoercibleToNumber(test) {
}

function testNotCoercibleToPrimitive(hint, test) {
var supportsToPrimitive = typeof Symbol !== "undefined" && !!Symbol.toPrimitive;

function MyError() {}

// ToPrimitive: input[@@toPrimitive] is not callable (and non-null)
test(TypeError, {[Symbol.toPrimitive]: 1});
test(TypeError, {[Symbol.toPrimitive]: {}});
if (supportsToPrimitive) {
test(TypeError, {[Symbol.toPrimitive]: 1});
test(TypeError, {[Symbol.toPrimitive]: {}});

// ToPrimitive: input[@@toPrimitive] returns object
test(TypeError, {[Symbol.toPrimitive]: function() { return Object(1); }});
test(TypeError, {[Symbol.toPrimitive]: function() { return {}; }});
// ToPrimitive: input[@@toPrimitive] returns object
test(TypeError, {[Symbol.toPrimitive]: function() { return Object(1); }});
test(TypeError, {[Symbol.toPrimitive]: function() { return {}; }});

// ToPrimitive: input[@@toPrimitive] throws
test(MyError, {[Symbol.toPrimitive]: function() { throw new MyError(); }});
// ToPrimitive: input[@@toPrimitive] throws
test(MyError, {[Symbol.toPrimitive]: function() { throw new MyError(); }});
}

// OrdinaryToPrimitive: method throws
testCoercibleToPrimitiveWithMethod(hint, function() {
Expand Down Expand Up @@ -341,7 +353,9 @@ function testNotCoercibleToString(test) {
}

// Symbol -> TypeError
testPrimitiveValue(Symbol("1"));
if (typeof Symbol !== "undefined") {
testPrimitiveValue(Symbol("1"));
}

// ToPrimitive
testNotCoercibleToPrimitive("string", test);
Expand All @@ -351,7 +365,9 @@ function testCoercibleToBooleanTrue(test) {
test(true);
test(1);
test("string");
test(Symbol("1"));
if (typeof Symbol !== "undefined") {
test(Symbol("1"));
}
test({});
}

Expand Down Expand Up @@ -434,7 +450,9 @@ function testNotCoercibleToBigInt(test) {
testPrimitiveValue(TypeError, 0);
testPrimitiveValue(TypeError, NaN);
testPrimitiveValue(TypeError, Infinity);
testPrimitiveValue(TypeError, Symbol("1"));
if (typeof Symbol !== "undefined") {
testPrimitiveValue(TypeError, Symbol("1"));
}

// when a String parses to NaN -> SyntaxError
function testStringValue(string) {
Expand Down