Editorial: Minor editorial changes #3264
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3264 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 22 22
Lines 10408 10408
Branches 1816 1816
=======================================
Hits 10194 10194
Misses 196 196
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I noticed a few places where it wasn't being used.
"a Object" → "an Object"
The paragraph with the M11L example is also no longer necessary because as per proposal-intl-era-monthcode, East Asian lunisolar calendars have PlainMonthDay ISO reference years fixed in a table.
This text should have been updated when NonISOMonthDayToISOReferenceDate was split from CalendarMonthDayToISOReferenceDate. The ISO8601-specific behaviour does not occur in NonISOMonthDayToISOReferenceDate, so refer to it in the other operation instead.
See new ECMA-262 convention tc39/ecma262#3733
See new ECMA-262 convention tc39/ecma262#3733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, updating to new editorial convention from ECMA-262 to prefer "else" over "otherwise" (tc39/ecma262#3733)