Normative: Block formatting plain Temporal objects in non-UTC formatter #3247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes DateTimeFormat's various formatting methods throw when given a Temporal.Plain___ object, unless the formatter's time zone is UTC. The one-off formatter objects constructed in the Plain types' toLocaleString methods get their time zone overridden to be UTC. Closes: #3212
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 22 22
Lines 10397 10397
Branches 1828 1828
=======================================
Hits 10126 10126
Misses 247 247
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I don't like this solution at all. #3246 provides a clearer developer experience, IMO. |
Member
I agree. |
Collaborator
Author
|
Decided against this solution in the Temporal meeting of 2026-01-15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes DateTimeFormat's various formatting methods throw when given a Temporal.Plain___ object, unless the formatter's time zone is UTC.
The one-off formatter objects constructed in the Plain types' toLocaleString methods get their time zone overridden to be UTC.
Closes: #3212