Editorial: Refactor ISODateSurpasses parallel to NonISODateSurpasses #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 22 22
Lines 10401 10408 +7
Branches 1814 1816 +2
=======================================
+ Hits 10187 10194 +7
Misses 196 196
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
force-pushed
the
editorial-isodatesurpasses
branch
from
ff80068 to
eae02f2
Compare
Collaborator
Author
|
Updated this PR to make the non-ISO8601 calculations in the polyfill work according to the adopted normative change in proposal-intl-era-monthcode. |
ptomato
force-pushed
the
editorial-isodatesurpasses
branch
from
eae02f2 to
f407a7f
Compare
These can be calculated calendar-independently, so we can save the cost of converting an ISO date to calendar space and back for no reason.
See tc39/proposal-intl-era-monthcode#101. This changes the general outline of ISODateSurpasses so that it parallels the outline of NonISODateSurpasses in the Intl Era/Month Code proposal as proposed in the PR, and adds the CompareSurpasses operation. Also refactors the polyfill code, but keeps the optimizations we already had regarding not passing weeks and days to ISODateSurpasses.
ptomato
force-pushed
the
editorial-isodatesurpasses
branch
from
f407a7f to
aa7a1ae
Compare
Collaborator
Author
|
I pulled in the new test262 tests covering the Intl Era/Month Code change, and did some optimization on the polyfill. (The way I'd originally written this PR, was quite a lot slower than the status quo.) I'd appreciate a review on this soon. |
jenkins-chromium-github-sync bot
pushed a commit
to armarok/chromium
that referenced
this pull request
Jan 28, 2026
Uplift of unicode-org/icu4x#7514 (needs manual fixes) This implements the spec changes from tc39/proposal-intl-era-monthcode#101 and tc39/proposal-temporal#3245 Change-Id: Ifec012334bbc2fb9b6c988ac4c32765d7444d8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7525051 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575639}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 28, 2026
Uplift of unicode-org/icu4x#7514 (needs manual fixes) This implements the spec changes from tc39/proposal-intl-era-monthcode#101 and tc39/proposal-temporal#3245 Change-Id: Ifec012334bbc2fb9b6c988ac4c32765d7444d8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7525051 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1575639} NOKEYCHECK=True GitOrigin-RevId: 2f5a9f8494dceff61afdffead41d8fd755869f36
Ms2ger
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See tc39/proposal-intl-era-monthcode#101. This changes the general outline of ISODateSurpasses so that it parallels the outline of NonISODateSurpasses in the Intl Era Monthcode proposal as proposed in the PR.
Also refactors the polyfill code, but keeps the optimizations we already had regarding not passing weeks and days to ISODateSurpasses.
(Draft; merge if tc39/proposal-intl-era-monthcode#101 is adopted)