add optional marker for early exits in algorithm steps#683
Open
michaelficarra wants to merge 7 commits intomainfrom
Open
add optional marker for early exits in algorithm steps#683michaelficarra wants to merge 7 commits intomainfrom
michaelficarra wants to merge 7 commits intomainfrom
Conversation
Member
|
This should also mark |
michaelficarra
force-pushed
the
mark-early-exits
branch
from
05b3f53 to
0083a75
Compare
Member
Author
|
I added support for the 262 macros (though I don't love hard-coding that into ecmarkup) and I updated the styling to match user code annotations: 
Here's what it looks like with both of them on: 
|
michaelficarra
force-pushed
the
mark-early-exits
branch
from
0083a75 to
596e585
Compare
michaelficarra
commented
Mar 29, 2026
| } | ||
|
|
||
| // get text content of an element excluding nested <ol> children | ||
| function ownTextContent(el: Element): string { |
Member
Author
There was a problem hiding this comment.
Depending on whether #684 lands before this, this function may need to be pulled from the helper in utils.
Member
There was a problem hiding this comment.
#684 did land first, and I have a complaint about the ownTextContent name: https://github.com/tc39/ecmarkup/pull/684/changes#r3011694290
bakkot
reviewed
Mar 29, 2026
michaelficarra
force-pushed
the
mark-early-exits
branch
from
596e585 to
b993f73
Compare
michaelficarra
force-pushed
the
mark-early-exits
branch
from
b993f73 to
8a0973b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #673. I went with a global toggle like we use with user code annotations, rather than per-algorithm.
Disclaimer: I used AI in the process of making this PR.