Skip to content

Terms & Defs style rule #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gesa wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −8
Open

Terms & Defs style rule #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions css/print.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,19 +660,24 @@ p.ECMAaddress {
margin: 0;
}

#sec-terms-and-definitions dfn {
[id$=terms-and-definitions] dfn {
Copy link
Copy Markdown
Member

@gibson042 gibson042 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer matching on class rather than id suffix, and no matter what such special behavior should be documented as part of the ecmarkup contract.

Suggested change
[id$=terms-and-definitions] dfn {
.ecma-terms-and-definitions dfn {

font-style: normal;
}

#sec-terms-and-definitions h1 .secnum {
[id$=terms-and-definitions] emu-clause h1 {
font-size: 10pt;
-prince-bookmark-level: none;
}

[id$=terms-and-definitions] h1 .secnum {
display: block;
}

#sec-terms-and-definitions > h1 > .secnum {
[id$=terms-and-definitions] > h1 > .secnum {
display: inline;
}

#sec-terms-and-definitions h1 + p {
[id$=terms-and-definitions] h1 + p {
margin-top: 0;
}

Expand Down
13 changes: 9 additions & 4 deletions test/baselines/generated-reference/assets-inline.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3917,19 +3917,24 @@
margin: 0;
}

#sec-terms-and-definitions dfn {
[id$=terms-and-definitions] dfn {
font-style: normal;
}

#sec-terms-and-definitions h1 .secnum {
[id$=terms-and-definitions] emu-clause h1 {
font-size: 10pt;
-prince-bookmark-level: none;
}

[id$=terms-and-definitions] h1 .secnum {
display: block;
}

#sec-terms-and-definitions > h1 > .secnum {
[id$=terms-and-definitions] > h1 > .secnum {
display: inline;
}

#sec-terms-and-definitions h1 + p {
[id$=terms-and-definitions] h1 + p {
margin-top: 0;
}

Expand Down