Editorial: Reword loop in ValidateAndApplyPropertyDescriptor#3773
Editorial: Reword loop in ValidateAndApplyPropertyDescriptor#3773
Conversation
spec.html
Outdated
| 1. Replace the property named _P_ of object _O_ with a data property whose [[Configurable]] and [[Enumerable]] attributes are set to _configurable_ and _enumerable_, respectively, and whose [[Value]] and [[Writable]] attributes are set to the value of the corresponding field in _Desc_ if _Desc_ has that field, or to the attribute's <emu-xref href="#table-object-property-attributes">default value</emu-xref> otherwise. | ||
| 1. Else, | ||
| 1. For each field of _Desc_, set the corresponding attribute of the property named _P_ of object _O_ to the value of the field. | ||
| 1. For each field name _F_ of _Desc_, set the attribute _F_ of the property named _P_ of object _O_ to the value _Desc_'s _F_ field. |
There was a problem hiding this comment.
Ecmarkup interprets the first variable name after "For each" as a variable declaration. We could fix it in Ecmarkup for this specific case, but it's easier to tweak our wording instead.
|
The rendered spec for this PR is available as a single page at https://tc39.es/ecma262/pr/3773 and as multiple pages at https://tc39.es/ecma262/pr/3773/multipage . |
michaelficarra
left a comment
There was a problem hiding this comment.
This is an improvement, so approving. But should we revisit #3406? Let's talk about it in the editor call.
linusg
left a comment
There was a problem hiding this comment.
Worth pointing out that 402 has [[<var>]] as an editorial extension for dynamic field access, if used sparingly (they don't) I think it's an improvement over doing field access using prose like this.
|
I would prefer to avoid introducing the |
aa36f37 to
5781133
Compare
5781133 to
eef2528
Compare
Minor tweak to avoid a false positive when linting for re-declared parameters (ref tc39/ecmarkup#679, #3768)