Skip to content

Editorial: Reword loop in ValidateAndApplyPropertyDescriptor#3773

Merged
ljharb merged 1 commit intotc39:mainfrom
nicolo-ribaudo:prepare-for-lint-reassign-arfs
Mar 26, 2026
Merged

Editorial: Reword loop in ValidateAndApplyPropertyDescriptor#3773
ljharb merged 1 commit intotc39:mainfrom
nicolo-ribaudo:prepare-for-lint-reassign-arfs

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Minor tweak to avoid a false positive when linting for re-declared parameters (ref tc39/ecmarkup#679, #3768)

spec.html Outdated
1. Replace the property named _P_ of object _O_ with a data property whose [[Configurable]] and [[Enumerable]] attributes are set to _configurable_ and _enumerable_, respectively, and whose [[Value]] and [[Writable]] attributes are set to the value of the corresponding field in _Desc_ if _Desc_ has that field, or to the attribute's <emu-xref href="#table-object-property-attributes">default value</emu-xref> otherwise.
1. Else,
1. For each field of _Desc_, set the corresponding attribute of the property named _P_ of object _O_ to the value of the field.
1. For each field name _F_ of _Desc_, set the attribute _F_ of the property named _P_ of object _O_ to the value _Desc_'s _F_ field.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ecmarkup interprets the first variable name after "For each" as a variable declaration. We could fix it in Ecmarkup for this specific case, but it's easier to tweak our wording instead.

@github-actions
Copy link
Copy Markdown

The rendered spec for this PR is available as a single page at https://tc39.es/ecma262/pr/3773 and as multiple pages at https://tc39.es/ecma262/pr/3773/multipage .

Copy link
Copy Markdown
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, so approving. But should we revisit #3406? Let's talk about it in the editor call.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Mar 24, 2026
Copy link
Copy Markdown
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, so approving. But should we revisit #3406? Let's talk about it in the editor call.

I'd be happy with #3406, but happier still with driving from the table that we already have.

Copy link
Copy Markdown
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth pointing out that 402 has [[<var>]] as an editorial extension for dynamic field access, if used sparingly (they don't) I think it's an improvement over doing field access using prose like this.

@bakkot
Copy link
Copy Markdown
Member

bakkot commented Mar 24, 2026

I would prefer to avoid introducing the [[<var>]] syntax to 262. Generally I would like to minimize the amount of novel notation in the specification.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 24, 2026
ljharb pushed a commit to nicolo-ribaudo/ecma262 that referenced this pull request Mar 25, 2026
@ljharb ljharb force-pushed the prepare-for-lint-reassign-arfs branch from aa36f37 to 5781133 Compare March 25, 2026 17:14
@ljharb ljharb force-pushed the prepare-for-lint-reassign-arfs branch from 5781133 to eef2528 Compare March 25, 2026 17:15
@ljharb ljharb added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Mar 25, 2026
@ljharb ljharb merged commit eef2528 into tc39:main Mar 26, 2026
10 of 11 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the prepare-for-lint-reassign-arfs branch March 30, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor call to be discussed in the next editor call editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants