-
Notifications
You must be signed in to change notification settings - Fork 1
Search #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hubwoop
wants to merge
7
commits into
tbolender:master
Choose a base branch
from
hubwoop:search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Search #21
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f555d3a
* search wip
hubwoop 3c84f55
* makes search case sensitive
hubwoop d8a592b
* fix refresh hanging
hubwoop f756c5e
* increase parsers upper limit (search can yield more than 999 posts)
hubwoop de9685c
* show query in search activity
hubwoop f75dd3f
Rename .java to .kt
hubwoop 93aaa95
* fix typo
hubwoop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
app/src/main/java/de/timbolender/fefereader/ui/SearchableActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| package de.timbolender.fefereader.ui | ||
|
|
||
| import android.app.SearchManager | ||
| import android.content.Intent | ||
| import android.os.Build | ||
| import androidx.lifecycle.LiveData | ||
| import androidx.lifecycle.ViewModelProvider | ||
| import androidx.paging.PagedList | ||
| import de.timbolender.fefereader.db.DataRepository | ||
| import de.timbolender.fefereader.db.Post | ||
| import de.timbolender.fefereader.network.Updater | ||
| import de.timbolender.fefereader.viewmodel.SearchViewModel | ||
| import java.io.IOException | ||
| import java.text.ParseException | ||
| import java.util.concurrent.CompletableFuture | ||
| import java.util.concurrent.Executor | ||
| import java.util.concurrent.Executors | ||
|
|
||
| class SearchableActivity : PostListActivity() { | ||
| public override fun getPostPagedList(): LiveData<PagedList<Post>> { | ||
| // Get the intent, verify the action and get the query | ||
| if (Intent.ACTION_SEARCH != intent.action) { | ||
| throw RuntimeException() | ||
| } | ||
| val query = intent.getStringExtra(SearchManager.QUERY) ?: throw RuntimeException() | ||
|
|
||
| title = String.format("Suchergebnisse: %s", query) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move static text to translatable strings |
||
| val repository = DataRepository(this) | ||
| val updater = Updater(repository) | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { | ||
| CompletableFuture.runAsync { | ||
| try { | ||
| updater.update(query) | ||
| } catch (e: ParseException) { | ||
| e.printStackTrace() | ||
| } catch (e: IOException) { | ||
| e.printStackTrace() | ||
| } | ||
| } | ||
| } else { | ||
| val executor: Executor = Executors.newSingleThreadExecutor() | ||
| executor.execute { | ||
| try { | ||
| updater.update(query) | ||
| } catch (e: ParseException) { | ||
| e.printStackTrace() | ||
| } catch (e: IOException) { | ||
| e.printStackTrace() | ||
| } | ||
| } | ||
| } | ||
| val vm = ViewModelProvider(this)[SearchViewModel::class.java] | ||
| return vm.getPostsPaged(query) | ||
| } | ||
|
|
||
| public override fun isUpdateOnStartEnabled(): Boolean { | ||
| return true | ||
| } | ||
|
|
||
| public override fun isRefreshGestureEnabled(): Boolean { | ||
| return false | ||
| } | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
app/src/main/java/de/timbolender/fefereader/viewmodel/SearchViewModel.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package de.timbolender.fefereader.viewmodel | ||
|
|
||
| import android.app.Application | ||
| import androidx.lifecycle.AndroidViewModel | ||
| import androidx.lifecycle.LiveData | ||
| import androidx.paging.PagedList | ||
| import androidx.paging.toLiveData | ||
| import de.timbolender.fefereader.db.DataRepository | ||
| import de.timbolender.fefereader.db.Post | ||
|
|
||
| class SearchViewModel(app: Application): AndroidViewModel(app) { | ||
| private val repository: DataRepository = DataRepository(app) | ||
|
|
||
| fun getPostsPaged(query: String): LiveData<PagedList<Post>> { | ||
| return repository.findPostsByContent(query).toLiveData(20) | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The activity has no back arrow in the bar. I would like to keep it consistent with the DetailsActivity.