[not ready for merge yet] R-package#2
Open
dselivanov wants to merge 16 commits intotbjohns:masterfrom
Open
Conversation
… dense matrix support
…err to R counterparts
- add "max non-zero" parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1. Not ready for merge yet:
squared,logisticCould you please check C++ part - especially headers and macros which I defined to use R's stdout, stderr management (this is CRAN requirement - R pkg should not touch C stdout/stderr and use R's API for that).
NOTE that
RcppExports.RandRcppExports.cppare auto-generated files, no need to check them (not sure how are you familiar with R, so want to make sure you won't have extra work trying to understand them).