Skip to content

Comments

Reflect a proper error by response code#83

Open
jalkoby wants to merge 1 commit intotaxjar:masterfrom
jalkoby:patch-1
Open

Reflect a proper error by response code#83
jalkoby wants to merge 1 commit intotaxjar:masterfrom
jalkoby:patch-1

Conversation

@jalkoby
Copy link

@jalkoby jalkoby commented Aug 25, 2022

In case of 502 response code TaxJar raises base TaxJar::Error rather than TaxJar::Error::ServerError which is more accurate and allows to handle only server side errors

In case of 502 response code TaxJar raises base TaxJar::Error rather than  TaxJar::Error::ServerError which is more accurate and allows to handle only server side errors
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jalkoby
Copy link
Author

jalkoby commented Nov 3, 2022

@CLAassistant the page doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants