Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for your sharing. I finally understand the encoding strategy for Wifi standard via your code.
When I read your Matlab code, I found that the decoding algorithm could have better performance if matrix multiplication could be implemented.Matlab is very good at dealing with matrix! I use sparse matrix and matrix multiplication instead of for loops. The result seems to be exciting. In my 2015 mbp, I got roughly x7.66 times performance improvements! I think you should try that.
I only changed the BP algorithm. I didn't touch the Min-Sum algorithm, but I think the same idea will also work. Sorry for messing up the decoding strategy. If time permits, I will also make the code compatible to
Min-Sum.
By the way, I also changed the encoder to get rid of variables like row_mat, col_mat. In my program, if I define the parity check matrix H to be a sparse matrix, then encoder could also have a little better performance.
Best
qizhu8