Skip to content

feat: Colored theme reactive tray icons for MacOS#270

Open
johnyburd wants to merge 5 commits intotauri-apps:devfrom
johnyburd:themed-icon
Open

feat: Colored theme reactive tray icons for MacOS#270
johnyburd wants to merge 5 commits intotauri-apps:devfrom
johnyburd:themed-icon

Conversation

@johnyburd
Copy link

Currently on MacOS you can set your icon as a template to have the icon change color dynamically with the bar's theme. Unfortunately this prevents using colors in your system icon since the image is used as a mask. This PR adds the ability to have colored icons that react to the system bar's theme.

VERT_Screen.Recording.2025-07-16.at.1.02.18.PM.webm

There is a little more clean up to do, but I figured I'd open the PR to see if it's something you're interested in merging before I spend more time on it. Please let me know if you see any major problems with this approach. I'm also open to taking a stab at implementing similar functionality for windows.

@FabianLars
Copy link
Member

something you're interested in merging

sure, why not

Please let me know if you see any major problems with this approach

nothing with the approach. but you could use more of objc2_app_kit for the is_dark logic instead of your extern C stuff similar to what winit does for example https://github.com/rust-windowing/winit/blob/e7a6034b559dfdd23a7eaa8b9bba6e88d621221b/winit-appkit/src/window_delegate.rs#L2052

@FabianLars
Copy link
Member

FabianLars commented Jul 16, 2025

oh also, we'll need your commits signed to be able to merge the pr https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

setting that up earlier rather than later/afterwards makes your life easier.

@johnyburd johnyburd marked this pull request as ready for review July 21, 2025 16:38
@johnyburd johnyburd changed the title Colored theme reactive tray icons for MacOS feat: Colored theme reactive tray icons for MacOS Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants