feat: Colored theme reactive tray icons for MacOS#270
Open
johnyburd wants to merge 5 commits intotauri-apps:devfrom
Open
feat: Colored theme reactive tray icons for MacOS#270johnyburd wants to merge 5 commits intotauri-apps:devfrom
johnyburd wants to merge 5 commits intotauri-apps:devfrom
Conversation
Member
sure, why not
nothing with the approach. but you could use more of objc2_app_kit for the is_dark logic instead of your extern C stuff similar to what winit does for example https://github.com/rust-windowing/winit/blob/e7a6034b559dfdd23a7eaa8b9bba6e88d621221b/winit-appkit/src/window_delegate.rs#L2052 |
Member
|
oh also, we'll need your commits signed to be able to merge the pr https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits setting that up earlier rather than later/afterwards makes your life easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on MacOS you can set your icon as a template to have the icon change color dynamically with the bar's theme. Unfortunately this prevents using colors in your system icon since the image is used as a mask. This PR adds the ability to have colored icons that react to the system bar's theme.
VERT_Screen.Recording.2025-07-16.at.1.02.18.PM.webm
There is a little more clean up to do, but I figured I'd open the PR to see if it's something you're interested in merging before I spend more time on it. Please let me know if you see any major problems with this approach. I'm also open to taking a stab at implementing similar functionality for windows.