The SetForegroundWindow function panicks in Windows 7.#245
Open
uuhan wants to merge 3 commits intotauri-apps:devfrom
Open
The SetForegroundWindow function panicks in Windows 7.#245uuhan wants to merge 3 commits intotauri-apps:devfrom
SetForegroundWindow function panicks in Windows 7.#245uuhan wants to merge 3 commits intotauri-apps:devfrom
Conversation
amrbashir
requested changes
Apr 17, 2025
Member
amrbashir
left a comment
There was a problem hiding this comment.
Could we use windows-version crate to only apply this hack on Windows 7?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes the panic occurs when click the system tray in Windows 7.
I dont know if
Windows 7is still supported, but use theAttachThreadInputtrick saves my Tauri app.Referenced this thread: https://stackoverflow.com/questions/3772233/win32-setforegroundwindow-unreliable