(store): Improved type-safety of JavaScript functions#2791
Open
theinfinit wants to merge 1 commit intotauri-apps:v2from
Open
(store): Improved type-safety of JavaScript functions#2791theinfinit wants to merge 1 commit intotauri-apps:v2from
theinfinit wants to merge 1 commit intotauri-apps:v2from
Conversation
Contributor
Package Changes Through dcb0ff2There are 2 changes which include cli with minor, cli-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
|
Cool! I'm fan of this, but like you said, this is a breaking change, so we would probably need to wait for v3 |
|
I was just complaining about how I can't pass generics to the store. Great to know this is coming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposition to overhaul the typescript definitions of
storeplugin.Why?
Current approach is error prone and cumbersome to work with. Setters are basically untyped and getters require manual type provisioning for each call.
Note
As far as TypeScript types go, this is a breaking change.
Disclaimer
Everything written by hand. No form of "AI" was involved. Feel free to ask questions about the code.
Example
Example below is outlining the workflow and areas of improvement.