Skip to content

Fix possible buffer overflow in addMultirowsImg #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bptato wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix possible buffer overflow in addMultirowsImg #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions anchor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,13 @@ addMultirowsImg(Buffer *buf, AnchorList *al)
a->slave = TRUE;
a->image = img;
a->end.pos = pos + ecol - col;
/* TODO:
* This is a hack to avoid adding images positioned on the wrong
* line outside line bounds (which would cause a buffer overrun).
* The actual bug is most likely in the image placement code.
*/
if (pos < 0 || a->end.pos > l->size)
continue;
for (k = pos; k < a->end.pos; k++)
l->propBuf[k] |= PE_IMAGE;
if (a_href.url) {
Expand Down