remove hardcoded compile path on windows #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatethurston
force-pushed
the
tate/rm-hardcoded-compile-path-windows
branch
from
fc819d2 to
68feecf
Compare
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory
tatethurston
force-pushed
the
tate/rm-hardcoded-compile-path-windows
branch
from
0dec265 to
4617ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.