Merged
Conversation
Katrin-kudryash
force-pushed
the
issues/1173
branch
from
e79c5d4 to
215142a
Compare
Contributor
Author
Scr.mov |
Katrin-kudryash
force-pushed
the
issues/1173
branch
from
215142a to
2d5a2dd
Compare
tsumo
requested changes
Apr 10, 2025
|
|
||
| const SheepLogoWithTips: FC = () => { | ||
| const [index, setIndex] = useState(getRandomIndex(0)); | ||
| const [index, setIndex] = useState(getRandomIndex([].length)); |
| const popupRef = useRef<HTMLDivElement>(null); | ||
|
|
||
| const allTipsItems = useMemo(() => { | ||
| const allTipsallTipsItems = useMemo(() => { |
Collaborator
There was a problem hiding this comment.
Name this memo allTips, remove local variable inside and return array
tsumo
requested changes
Apr 10, 2025
|
|
||
| const SheepLogoWithTips: FC = () => { | ||
| const [index, setIndex] = useState(getRandomIndex(0)); | ||
| const [index, setIndex] = useState(getRandomIndex([].length)); |
Collaborator
There was a problem hiding this comment.
It should be allTips.length
Katrin-kudryash
force-pushed
the
issues/1173
branch
from
2d5a2dd to
b422d80
Compare
tsumo
approved these changes
Apr 10, 2025
asabotovich
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR includes
Related issues
Resolve #1174