Skip to content

People management redesign#1469

Merged
asabotovich merged 1 commit intomainfrom
issue/1708
May 12, 2025
Merged

People management redesign#1469
asabotovich merged 1 commit intomainfrom
issue/1708

Conversation

@dobrain1
Copy link
Copy Markdown
Contributor

PR includes

  • Refactor

Copy link
Copy Markdown
Contributor

@asabotovich asabotovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove legace Edit modal on UserPage

return prisma.membership.create({
data: {
...data,
roles: { connect: { id: data.roles[0]?.id } },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this on client

@dobrain1 dobrain1 force-pushed the issue/1708 branch 4 times, most recently from 0a192d9 to f41e0e5 Compare May 7, 2025 13:42
<WarningModal
warningText={tr('Do you really want to remove a member {user} from the team {team}', {
user: membership.user.name as string,
team: membership.group.name as string,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid types casting


.ConfirmButton {
background-color: var(--danger-400);
color: var(--base-white);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this
use view prop

@asabotovich asabotovich changed the title chore(INTERNAL-1708): people management redesign People management redesign May 12, 2025
@dobrain1 dobrain1 requested a review from asabotovich May 12, 2025 14:06
<WarningModal
view="danger"
warningText={tr('Do you really want to remove a member {user} from the team {team}', {
user: membership.user.name || 'user',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fallback for email

@asabotovich asabotovich merged commit 64acc57 into main May 12, 2025
2 checks passed
@asabotovich asabotovich deleted the issue/1708 branch May 12, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants