This repository was archived by the owner on Mar 5, 2026. It is now read-only.
[WIP] Address feedback on code cleanup for 1.2.4 release#8
Closed
Copilot wants to merge 1 commit intorefactor/code-cleanup-1.2.4from
Closed
[WIP] Address feedback on code cleanup for 1.2.4 release#8Copilot wants to merge 1 commit intorefactor/code-cleanup-1.2.4from
Copilot wants to merge 1 commit intorefactor/code-cleanup-1.2.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mappings.javaclaims immutability butadd(Mapping)mutates internalArrayListadd(Mapping mapping)to create a newMappingsinstance instead of mutatingthisaddmethods that incorrectly say "Returns this instance" → "Returns a new instance"@SuppressWarningscomment which contradicts the immutability claim💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.