[RFC] Trace recording in tezos by Ngoguey42 · Pull Request #16 · tarides/tezos

Ngoguey42 · 2021-10-05T12:09:59Z

The commits should help you understand the refactorings that I made on existing code. Every commit from and after lib_context: Restore compilation compile.

samoht · 2021-10-05T12:22:14Z

src/lib_context/context.ml

 type t = context

-module type S = Tezos_context_sigs.Context.S
+module type S = Tezos_context_sigs.Context.MEM


Why did you rename this? This not the signature of the read-only backend :-)

I made Tezos_context_sigs.Context.S be the signature of the full lib_context implementation (which used to be lib_context/context.mli).

I can look for a better naming than MEM for the old Tezos_context_sigs.Context.S

samoht · 2021-10-05T12:26:33Z

src/lib_context/context_impl.ml

  {Logs.report}

-let index_log_size = ref None
+let index_log_size = Env.(v.index_log_size)


This commit (d51fbed) should be upstreamed separately (it's a good change on its own).

(also for only accessing fields, I would write it as v.Env.index_log_size and so on)

(also for only accessing fields, I would write it as v.Env.index_log_size and so on)

v is in Env, so v.Env wouldn't work.

Do you think I should rework the Env module?

v is in Env, so v.Env wouldn't work.

Do you think I should rework the Env module?

Ha yes sorry I was confused. Is there a way to not use a global variable in Env (and thread a local paramater around instead?)

Yes, I can get rid of the global variable and replace it with a Env.get : unit -> Env.t thunk that derives Sys.argv each time it is called.

that's a good idea only if it is called only once :-)

It would get called multiple times. I'm not sure how to do otherwise :(

can you add that env value to Context.t ? if not, don't worry too much and keep a global state.

Unfortunately the env needs to be read before a Context.t is instantiated

as long as it's read once it's ok :-)

Splits the protocol unit test jobs over multiple runners. Furthermore, tweak the `test_script_wrapper.sh` and the Makefile targets using it so that dune is invoked once with several targets, instead of one invocation per target. Thus, dune parallelism is exploited.

CI/Tests: manually balance unit tests See merge request tezos/tezos!4057

Add selected_snapshot RPC Closes #2485 See merge request tezos/tezos!4479

Proto: compile the protocol environment without Stdlib (fixes #2209) Closes #2209 See merge request tezos/tezos!4482

Tx_rollup,Proto: remove fixme See merge request tezos/tezos!4531

Proto,Tx_rollups: Inbox message count limit See merge request tezos/tezos!4548

doc: explicit RPC path prefixes See merge request tezos/tezos!4570

Tx rollup,Proto: clean empty balance in the context. Closes #2495 See merge request tezos/tezos!4594

Proto: fix https://gitlab.com/tezos/tezos/-/issues/2084 Closes #2554 and #2084 See merge request tezos/tezos!4457

…ster' Add tzip info about backwards compatibility to the doc See merge request tezos/tezos!4544

Tx_rollup: fix typos and constants in python See merge request tezos/tezos!4566

Ngoguey42 · 2022-03-17T13:12:30Z

src/lib_context/recording/shim.ml


  let init ?patch_context:user_patch_context_opt ?readonly
-      (* ?indexing_strategy *) x =
+      ?(indexing_strategy = `Minimal) x =


No need to put the minimal here

Ngoguey42 force-pushed the new-action-trace-recording branch from 8f90c92 to 277ffbb Compare October 5, 2021 12:18

samoht reviewed Oct 5, 2021

View reviewed changes

Ngoguey42 force-pushed the new-action-trace-recording branch from 277ffbb to f7f6cd0 Compare October 27, 2021 12:16

Ngoguey42 force-pushed the new-action-trace-recording branch 2 times, most recently from 0052b42 to 69c2de3 Compare December 10, 2021 13:48

Ngoguey42 force-pushed the new-action-trace-recording branch 3 times, most recently from 965a643 to a57a18c Compare January 11, 2022 17:29

maiste force-pushed the new-action-trace-recording branch from a57a18c to 2e1586c Compare January 25, 2022 10:03

Ngoguey42 force-pushed the new-action-trace-recording branch from 2e1586c to b25d227 Compare February 16, 2022 13:56

arvidj and others added 19 commits February 22, 2022 13:12

CI: sanitize coverage artifact names and merged file names

048c7a9

Merge branch 'arvid@rebalance-unittests' into 'master'

5dc64bd

CI/Tests: manually balance unit tests See merge request tezos/tezos!4057

Proto: expose snapshot index computation function

17412d2

Proto: register a RPC to query snapshot indexes

7dd14d3

Proto/Ithaca: backport selected_snapshot RPC via the plugin

9956c1c

Docs: fix modified snapshotting constants

a2ad129

Changes: add corresponding entry

bfc99f7

Merge branch 'vbot@add_selected_snapshot_rpc' into 'master'

59515c3

Add selected_snapshot RPC Closes #2485 See merge request tezos/tezos!4479

Proto: compile the protocol environment without Stdlib (fixes #2209)

8852a01

Merge branch 'env' into 'master'

a6abacc

Proto: compile the protocol environment without Stdlib (fixes #2209) Closes #2209 See merge request tezos/tezos!4482

Tx_rollup,Proto: use environment size for public key

7730346

Merge branch 'tx_rollup@bls-pk-size' into 'master'

e6a61aa

Tx_rollup,Proto: remove fixme See merge request tezos/tezos!4531

Tests/Tezt: make RPC.get_block_hash return strings

3ffe332

Tests/Tezt/voting.ml: no need for manual tezos_proto file

25f7aa3

Tests/Tezt/voting.ml: add and use period_kind type

f4d1461

Tests/Tezt: facility for setting protocol overrides in node config

12525e6

Tests/Tezt/voting.ml: add user-activated protocol override test

bde8a49

Tests/Flextesa: remove sandboxes:u-a-u and sandboxes:daemons-upgrade

fde7066

Marge Bot and others added 13 commits March 2, 2022 09:31

Merge branch 'tx_rollup@inbox_size_limit' into 'master'

e0eb36d

Proto,Tx_rollups: Inbox message count limit See merge request tezos/tezos!4548

doc: explicit RPC path prefixes

885a20a

Merge branch 'nic@rpc-prefixes-doc' into 'master'

5f7500c

doc: explicit RPC path prefixes See merge request tezos/tezos!4570

Tx_rollup,Proto: Add [remove] in the storage signature

f04b8ec

Tx_rollup,Proto: Remove empty balance from the context

763e2ed

Merge branch 'tx_rollup@remove-balance' into 'master'

e3c0526

Tx rollup,Proto: clean empty balance in the context. Closes #2495 See merge request tezos/tezos!4594

Proto: fix https://gitlab.com/tezos/tezos/-/issues/2084

90e680f

Merge branch 'random' into 'master'

988f427

Proto: fix https://gitlab.com/tezos/tezos/-/issues/2084 Closes #2554 and #2084 See merge request tezos/tezos!4457

Doc: add missing info from tzip

c306601

Merge branch 'astefano@add_missing_info_from_tb_tzip_to_doc' into 'ma…

d2f9543

…ster' Add tzip info about backwards compatibility to the doc See merge request tezos/tezos!4544

Python: Fix the limits in mockup

61fbe47

Tx_rollup,Proto: fix typo in register error

f3f39ea

Merge branch 'vch9@toru-fix-typo' into 'master'

f3bb4eb

Tx_rollup: fix typos and constants in python See merge request tezos/tezos!4566

Ngoguey42 force-pushed the new-action-trace-recording branch 2 times, most recently from 3da7ee3 to 9e3ba2f Compare March 2, 2022 14:50

Ngoguey42 and others added 12 commits March 2, 2022 17:16

lib_context: Rename Sigs.S to Sigs.TRUC

736528f

lib_context: Move context.mli to the end of sigs/context.ml

b81a9ba

lib_context: Normalise sigs/context.ml

f05b89c

lib_context: Extract interactions with TEZOS_CONTEXT to env.ml

a0f8e92

lib_context: Update header dates

2877dd3

lib_context: Add irmin stats

3c582a9

Recording

54411ae

Update of recording

a924bdf

Recording in lib_context

37098b4

Replay

948553b

Update of replay

889c5dd

Add support for snap export in summary

fb757a2

Ngoguey42 force-pushed the new-action-trace-recording branch from 9e3ba2f to fb757a2 Compare March 3, 2022 16:37

Introduce indexing strategy choice in replay

2b71f10

Ngoguey42 commented Mar 17, 2022

View reviewed changes

Conversation

Ngoguey42 commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ngoguey42 Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samoht Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Ngoguey42 commented Oct 5, 2021 •

edited

Loading

Ngoguey42 Oct 6, 2021 •

edited

Loading

samoht Oct 6, 2021 •

edited

Loading