-
Notifications
You must be signed in to change notification settings - Fork 247
feat: offline signer #7663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
feat: offline signer #7663
Conversation
Summary of ChangesHello @SWvheerden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a critical security enhancement by introducing a dedicated offline transaction signer. The new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new minotari_offline_signer binary, enabling secure offline signing of Tari transactions. The implementation leverages strong cryptographic primitives like Argon2id and ChaCha20-Poly1305 for key derivation and encryption, along with OS-native secure storage (Keychain, Credential Manager, Secret Service). The CLI provides a user-friendly interface with interactive prompts for sensitive data, and the accompanying README.md offers comprehensive usage instructions and critical security recommendations. Overall, this is a well-designed and important feature for enhancing transaction security.
Description
Adds a stand alone binary to do offline signing
fixes: #7630