fix: user pay for fee and replace by fee #7662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
fix_cumcumber
branch
from
baad8f7 to
362d341
Compare
SWvheerden
changed the title
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces fixes for 'user pay for fee' and 'replace by fee' wallet calls, along with updates to base node settings and several Cucumber tests. The changes appear to improve configurability and test realism. However, I've identified a potential issue in the output selection logic where a filter for unspent outputs has been removed, which could lead to errors during transaction creation. Additionally, there's a leftover debug print statement in the test code that should be removed.
base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes user pay for fee and replace by fee wallet calls
Fixes base node settings
Fixes some cucumber tests