checkpoint: list api fix numerical key ordering#1
Draft
Conversation
…xPolygon#1141) * chg: POS-2399: ganache bug workaround to reduce smoke_test time * chg: POS-2399: add echo log * chg: POS-2399: fix signer dump path * chg: POS-2399: log info * chg: POS-2399: fix script with proper signersDump length * chg: POS-2399: better comment
* chg: update deps / fix root folder for docker integration tests * chg: bump bor version * chg: bump deps * chg: bump deps * chg: update go version in GH CIs * chg: update go version in linter and makefile * chg: update go version in makefile * chg: change golangci-lint version * chg: fix linter / remove wsl
taratorio
changed the title
taratorio
commented
Mar 27, 2024
checkpoint/genesis.go
Outdated
| } | ||
| } | ||
|
|
||
| if err := keeper.MigrateCheckpointKeyV2(ctx); err != nil { |
Owner
Author
There was a problem hiding this comment.
TODOs:
- is this a good place to run the migration?
- is InitGenesis guaranteed to be run on process restart?
- test and see how long it takes - first impression is that this should be quick to complete given the level db table has only 60k entries in bor-mainnet
taratorio
commented
Mar 27, 2024
| // GetCheckpointKey appends prefix to checkpointNumber | ||
| func GetCheckpointKey(checkpointNumber uint64) []byte { | ||
| checkpointNumberBytes := []byte(strconv.FormatUint(checkpointNumber, 10)) | ||
| checkpointNumberBytes := sdk.Uint64ToBigEndian(checkpointNumber) |
Owner
Author
There was a problem hiding this comment.
this is the actual fix for having correct numerical ordering
taratorio
force-pushed
the
checkpoint-list-numerical-ordering
branch
from
a1044fe to
f13021b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description of what was done in this PR
Changes
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Nodes audience
In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it