Menu #16
Open
Menu #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self.menu = Menu.objects.create(chef=self.chef, title='foxy food', delivery=True ) | ||
| self.item = Item.objects.create(menu=self.menu, title="kibbles", size="the whole bowl", | ||
| price=13.33, description="food for foxy") |
Owner
There was a problem hiding this comment.
there should be one more line break here between setup and the first test!
| self.assertFalse(Menu.objects.filter(chef=self.chef).exists()) | ||
| menu = Menu.objects.create(chef=self.chef, title='foxy food', delivery=True ) | ||
| self.assertTrue(Menu.objects.filter(chef=self.chef).exists()) | ||
| self.assertFalse(Menu.objects.filter(title='foxys favorites').exists()) |
Owner
There was a problem hiding this comment.
you don't need to really test this part. I would just start on line 28 with the "assertTrue" that the menu exists. That way you can use the menu from setup (self.menu) (you'll have to change it in all the other places you reference "menu" as well so don't forget that). This test is more about testing the link between menu and item then it is about testing the menu creation. Make sense? (maybe we should rename this test to test_menu_item_link?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.