fix: multi-host fallback integration and accurate health status#3
Merged
fix: multi-host fallback integration and accurate health status#3
Conversation
Fixes: - Multi-host fallback now works in main chat loop - Accurate host health status display in /hosts command - Clear user feedback when fallback occurs or fails Changes: - internal/assistant/assistant.go: Add hostPool field, SetHostPool(), switchToFallbackProvider(), isHostRetryableError() - internal/provider/hostpool.go: Verify connectivity before marking healthy - cmd/repl.go: Wire HostPool to Assistant after initialization The HostPool was not connected to the Assistant, so automatic fallback never triggered during chat. Now when primary host fails, the system automatically switches to a healthy fallback host and notifies the user. Additionally, hosts were incorrectly marked healthy before actual connectivity verification. Now DetectModels() must succeed before a host is considered healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Changes:
The HostPool was not connected to the Assistant, so automatic fallback never triggered during chat. Now when primary host fails, the system automatically switches to a healthy fallback host and notifies the user.
Additionally, hosts were incorrectly marked healthy before actual connectivity verification. Now DetectModels() must succeed before a host is considered healthy.
Description
Brief description of what this PR does.
Related Issue
Fixes #(issue number) or Related to #(issue number)
Type of Change
How Has This Been Tested?
Describe the tests you ran:
Checklist
gofmt -s -l .shows no files (code is formatted)go vet ./...passesmake testpassesmake buildsucceeds