Merged
Conversation
- Converted Form.vue and ConditionBox.vue components to use the Composition API with `<script setup>`. - Enhanced state management by utilizing reactive and ref for form data and loading states. - Improved validation logic and error handling for form inputs. - Streamlined event handling and method definitions for better readability and maintainability. - Updated imports and component structure for consistency with Vue 3 standards.
…omponent - Changed WSClient import to named import for consistency. - Renamed route from 'MigrationEditor' to 'MigrateForm' for clarity in routing.
…and reactive state management TAP-6487 - Converted Form.vue and ConditionBox.vue to use the Composition API with `<script setup>`. - Replaced observable with reactive for form state management in Form.vue. - Improved data handling and validation logic for form inputs. - Injected form data into ConditionBox.vue for better state management. - Cleaned up commented-out code and improved overall component structure for clarity.
Perf/data validation
- Deleted App.tsx and related hooks (useI18n, useMessage) as they were no longer needed. - Updated App.vue to utilize the new i18n structure with useI18n. - Replaced direct i18n calls with ElMessage in ObjectList and ObjectTable components for improved messaging. - Cleaned up imports and ensured consistent usage of the new i18n methods across components.
…rm handling - Converted WebhookAlerts.vue to use the Composition API with `<script setup>`. - Improved form validation logic and state management using reactive and ref. - Updated i18n usage for better localization support. - Enhanced event handling and method definitions for clarity and maintainability. - Cleaned up imports and removed unused code for improved readability.
…in ConditionBox - Changed the border radius class in the error message component for improved styling. - Updated data mapping in ConditionBox.vue to correctly reference the response structure, ensuring accurate data handling. - Enhanced error handling by ensuring safe access to selected states in InfiniteSelect.vue.
…js and Editor.vue TAP-6488 - Replaced Vue import with named import for nextTick in command.js for consistency with Vue 3 standards. - Enhanced string interpolation in command.js for better readability. - Simplified checkMaterializedView method in Editor.vue by directly accessing query from this.$route. - Removed unnecessary comments and cleaned up code structure in Editor.vue and editor.js for improved clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.