Configuration = Done, Arbitrary length and Adaptable Configuration = Done, Less Laggy Karma Parties = Done #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 29, 2012 21:25
A new Thread Delay Approach, Sends a value to the database every 5 seconds. Schedules a new Thread.
Custom Format to support ONLY 6 slots, EASILY expandable.
Uses an array that automatically is linked to the integer of the rank. Lowest rank = 0, Highest = 5;
Stupid me....
This gives a 6 group max config, Will make it more efficiant with a PriorityQueue implementation of the Array. If tom's code wasn't so abstract to begin with then none of this would be possible. He either meant to make it abstract or he typed whatever came to mind as the easiest way after 1 second of thinking...
Abstracality is a great thing. An ArrayList could've been used but I'm just not comfertable that everything would be transferred in perfect order.
Everything is spiffy and spoffy! Arbitrary Config Length!
Ohh well...
Contributor
|
I have worked a lot on karma in my fork at https://github.com/cmastudios/karma and have a configuration with EVERYTHING configurable and haven't tested it much, maybe we could merge together somehow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is solid, you can change the priority queue implementation of the arbitration in the config reading to an ArrayList, I just feel more comfortable with what I have in the whole idea of a queue structure. You can drag it into the Warhub Server and it should generate exactly what you had the plugin hardcode set to. The Default configuration file is for the warhub.
Documentation:
How To work configuration
Ranks go from top to bottom!
so:
;;;
greybeard;2000;null;DarkGreen
moderator;1000;greybeard;DarkAqua
minimod;500;moderator;Aqua
Note: Group above is just there for dependency purposes with tom's code. It works well but in order for the reader to work it must go from top to bottom, which is much less confusing if you ask me. I don't want to first have to sort it by karma amount then operate on it.
Note 2: Chat Colors are everything in ChatColor enum so ChatColor.DARK_GREEN becomes DarkGreen and ChatColor.GREEN becomes Green
Note 3: There is no exception checking for if one group that is below has more karma than the group above it, I will leave it to the common sense of the people.