Simplified version of your classybrew library#4
Open
nulu137 wants to merge 3 commits intotannerjt:masterfrom
Open
Simplified version of your classybrew library#4nulu137 wants to merge 3 commits intotannerjt:masterfrom
nulu137 wants to merge 3 commits intotannerjt:masterfrom
Conversation
Owner
|
Thanks for submitting the pull request. I can take a look. Also, thanks for using the library and I hope it was useful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used your classybrew lib for our project OSTaps https://github.com/HsKA-OSGIS/OSTaps, which was a study project. I simplified the function for our project, added the possiblity of using two classes in the colorscheme (adapted from colorbrew). Also I removed the functionality of "choosing" the classification method, because we only wanted to implement jenks (natural breaks).
So of course it is not a great contribution(more a stepback) to your library, but our professor said we should at least send a pull request. And of course we give you credit in our repository.