Open
Conversation
Owner
|
Hi @darkfoxs96 and @peterksts , Just got your PRs requests. I will look at it first and further discuss with you. First glance of your PR shows some positive to my repo. Thanks |
Author
|
Hi, Okay. I use two accounts. Thanks |
Author
|
I'm using your go_smtp to my homecontrol: |
tangingw
reviewed
May 28, 2018
| User string | ||
| Password string | ||
| // SMTPServer stores host, port for SMTP map | ||
| type SMTPServer struct { |
Owner
There was a problem hiding this comment.
This part is redundant since you have defined in the Sender struct.
| @@ -1,4 +1,4 @@ | |||
| package main | |||
| package gomail | |||
Owner
There was a problem hiding this comment.
I would still want to retain the name either on gostmp or go_smtp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.