player: don't update progress when page is not focused#169
Merged
tamland merged 1 commit intotamland:masterfrom Dec 4, 2025
Merged
player: don't update progress when page is not focused#169tamland merged 1 commit intotamland:masterfrom
tamland merged 1 commit intotamland:masterfrom
Conversation
Fixes an issue where on Firefox, airsonic-refix uses ~50% CPU when playing a track. Even when not focused. The issue lies somewhere in the progress bar being updated form ontimeupdate Looking at a profile: RefreshDriver tick (70%) -> Update the rendering paint (55%) -> Paint (54%) Chrome seems not have the issue, maybe it's internally throttling when not focused. For Firefox, just not updating the store when the document is hidden dropped usage down to 8% from 50% for me.
Owner
|
Do you know if this is still an issue in the |
monowii
added a commit
to monowii/airsonic-refix
that referenced
this pull request
Dec 12, 2025
vue-slider-component has a default transition animation duration of 0.5s, which causes repaint each frame. Previous fix (tamland#169) blocked store updates when the page was hidden, which did not fully resolve the CPU usage issue (and broke lastfm scrobbling)
Owner
|
Reverted since this broke scrobble and play queue save |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where on Firefox, airsonic-refix uses ~50% CPU when playing a track. Even when not focused.
The issue lies somewhere in the progress bar being updated from ontimeupdate
Looking at a profile:
Chrome seems not have the issue, maybe it's internally throttling when not focused.
For Firefox, just not updating the store when the document is hidden dropped usage down to 8% from 50% for me