Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Make installable with webpack#18

Open
christiaanwesterbeek wants to merge 1 commit intotameraydin:masterfrom
christiaanwesterbeek:master
Open

Make installable with webpack#18
christiaanwesterbeek wants to merge 1 commit intotameraydin:masterfrom
christiaanwesterbeek:master

Conversation

@christiaanwesterbeek
Copy link

This change is required to allow ng-inline-edit to be importable with es6 and bundled with webpack and AngularJS 1.x. Without the change, this is the error that occurs when running the angular app.

Uncaught Error: [$injector:modulerr] Failed to instantiate module nprc-portal due to:
Error: [$injector:modulerr] Failed to instantiate module {} due to:
Error: [ng:areq] Argument 'module' is not a function, got Object

Btw, the tests were already failing before my changes on my local machine due to some PhantomJS problem and a requirement for an older Node.js version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant