Merge Karnov Group's excel-to-code with upstream excel_to_code#21
Merge Karnov Group's excel-to-code with upstream excel_to_code#21andreasDalsgaard wants to merge 13 commits intotamc:masterfrom
Conversation
same region as the value is located
…by be replaced with zeros
|
Thank you @andreasDalsgaard - this looks really helpful. I will write some tests before I merge to make sure I understand all the changes. With best wishes, Tom Sent with GitHawk |
| return array[((((int) row_number_v.number)-1)*columns)+(i-1)]; | ||
| } else { | ||
| last_good_match = i; | ||
| if(lookup_value_v.type == ExcelString && possible_match_v.type == ExcelString) |
There was a problem hiding this comment.
@andreasDalsgaard do you have an example spreadsheet where this is needed? I've been writing some tests of HLOOKUP and I haven't yet managed to come up with one that matches Excel, but needs this.
There was a problem hiding this comment.
Sorry, for the long delay in responding. This was done as part of a consulting task and released with permission from the client. However, the client owns the spreadsheets and cannot be shared. I also don't have access to the spreadsheets files any more. I will try ask them if we can provide an example.
Adding support for resetting individual sheets
Various changes related to named references
Changes for references optimized away (zero/nil)
Prevent unbounded recursion for hlookup's in same region