Implemented EXP, INT, and MONTH functions#13
Conversation
src/excel/excel_functions/month.rb
Outdated
There was a problem hiding this comment.
Is this line needed? Given you have already tested for nil in line 8?
|
Cool. Looks pretty close. Thanks. If you don't have time to look at my comments, then I'll give them a go at some point in the next few weeks and then merge. |
|
Great points! I'll implement your suggestions. Might take a few days. We move so fast here I just get it working first. Then refactor when time is available. But I'll make these changes as soon as possible. Thanks! Chris ----- Original Message ----- From: "Tom Counsell" notifications@github.com Cool. Looks pretty close. Thanks. If you don't have time to look at my comments, then I'll give them a go at some point in the next few weeks and then merge. — |
…xcel_to_code into exp_int_month_functions
This reverts commit d46088e. Conflicts: src/compile/ruby/map_formulae_to_ruby.rb src/excel/excel_functions.rb
3 participants
Wrote test and implementation for the following Excel functions
EXP
INT
MONTH