Skip to content

Conversation

@takurot
Copy link
Owner

@takurot takurot commented Jan 18, 2026

Summary

Resolved CS8618 warnings in 'IvfFlatVectorIndex.cs' by using property initializers.
Initially considered 'required', but switched to initializers to ensure backward compatibility with older snapshots (preventing JsonException on missing fields).

Changes

  • Replaced 'required' modifier with default value initialization ('= new()', '= null!').
  • Added regression test 'Load_MissingFields_ShouldHandleGracefully' to verify JSON compatibility.

Verification

  • 'dotnet build' passes without warnings.
  • 'dotnet test' passes (including new compatibility test case).

@takurot takurot changed the title fix(core): resolve IVF build warnings using required properties fix(core): use property initializers in Ivf DTOs (compatibility safe) Jan 18, 2026
@takurot takurot merged commit f9b7ba5 into main Jan 18, 2026
4 checks passed
@takurot takurot deleted the feature/fix-ivf-warnings branch January 18, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants