feature(currentState&test): verify if the currentState & test#4
Open
Dani-Rocha-Azevedo wants to merge 2 commits intotaktik:masterfrom
Open
feature(currentState&test): verify if the currentState & test#4Dani-Rocha-Azevedo wants to merge 2 commits intotaktik:masterfrom
Dani-Rocha-Azevedo wants to merge 2 commits intotaktik:masterfrom
Conversation
hubjac1
suggested changes
Sep 19, 2019
src/index.ts
Outdated
| * Verify if the currentState is the same state | ||
| * @param state | ||
| */ | ||
| currentStateIs(state: T) { |
Contributor
There was a problem hiding this comment.
Pour le nom de la méthode j'aurais plutôt mis isSameState.
Par-contre, il faut évité de mettre est type de retour implicite. ==> Il est péférable spécifier que le type de retour est un booléen
currentStateIs(state: T): Boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function currentStateIs / currentStateIsNot
Add setup karma with some tests