add check for prototype instanceof in case === fails#58
Open
samlecuyer wants to merge 2 commits intotakempf:masterfrom
Open
add check for prototype instanceof in case === fails#58samlecuyer wants to merge 2 commits intotakempf:masterfrom
samlecuyer wants to merge 2 commits intotakempf:masterfrom
Conversation
Sometimes the equality check fails, but the prototype check succeeds.
|
+1 had the same issue with React 16.6 (and no next.js) and this PR fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this component in with react ^16.3.1 and it works fine. However, when I embed it in an app that uses next.js, the equality check on the children fails. In this case, we should check to see if it's an instanceof.