Skip to content

add default tabIndex to DropdownTrigger#53

Open
vankhoawin wants to merge 1 commit intotakempf:masterfrom
vankhoawin:master
Open

add default tabIndex to DropdownTrigger#53
vankhoawin wants to merge 1 commit intotakempf:masterfrom
vankhoawin:master

Conversation

@vankhoawin
Copy link

Closes #44.

Taken from WebAIM:

tabindex="0" allows elements besides links and form elements to receive keyboard focus. It does not change the tab order, but places the element in the logical navigation flow, as if it were a link on the page.

@vankhoawin
Copy link
Author

vankhoawin commented Dec 7, 2017

I'm not sure whether you'd like to change it to a <button>, but without changing tags, this pull request could work.

@emplums
Copy link

emplums commented Mar 27, 2018

hey @Fauntleroy! Would it be possible to merge this one in? 🍩 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants