This repository was archived by the owner on Dec 24, 2025. It is now read-only.
chore: make github workflows work #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocchira
force-pushed
the
ysh/fix-ci-settings
branch
from
7fc89a9 to
d072c45
Compare
mocchira
commented
Aug 4, 2025
| # Run tests with all features | ||
| - name: Run complete tests | ||
| run: cargo test --all-features --doc | ||
| run: cargo test --features "default,snapshot_builder,fs_import,url_import,web,os_exit" --doc |
Contributor
Author
There was a problem hiding this comment.
現状 --all-features は動作しないので、我々が利用している features のみ enabled にしてテストするよう変更
mocchira
commented
Aug 4, 2025
| - name: web_features | ||
| run: cargo run --example web_features --features "web" | ||
| # - name: web_features | ||
| # run: cargo run --example web_features --features "web" |
Contributor
Author
There was a problem hiding this comment.
breaking changes の影響で動作しないため、一旦コメントアウト
mocchira
commented
Aug 4, 2025
| - name: websocket | ||
| run: cargo run --example websocket --features="web websocket" | ||
| # - name: websocket | ||
| # run: cargo run --example websocket --features="web websocket" |
mocchira
commented
Aug 4, 2025
| # Lint all the things | ||
| - name: Run clippy | ||
| run: cargo clippy --all-features | ||
| run: cargo clippy --features "default,snapshot_builder,fs_import,url_import,web,os_exit" |
Contributor
Author
There was a problem hiding this comment.
現状 --all-features は動作しないので、我々が利用している features のみ enabled にしてテストするよう変更
mocchira
commented
Aug 4, 2025
| @@ -0,0 +1,43 @@ | |||
| name: Rust Tests | |||
Contributor
Author
There was a problem hiding this comment.
中身は tests.yml と同じです。
既存のワークフローを修正しただけでは、CI が動作しなかったのですが、新規ワークフロー追加する事で動作するようになったので、tests.yml を削除し、本ファイルを新規作成しています
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.