Update MSRV to 1.75.0 and fix all rustc and clippy warnings

.gitignore

@@ -1,3 +1,4 @@
 /.vagga
 /target
 /Cargo.lock
+/.idea

CHANGELOG.md

@@ -0,0 +1,8 @@
+# Next
+
+- Update MSRV to 1.75.0, currently the older of rustc in Ubuntu LTS (Noble Numbat, 1.75.0) and Debian Stable (trixie, 1.85.0)
+  - Small syntactic tweaks to address all compiler and clippy warnings
+
+# 0.8.0
+
+Current version when changelog started

Cargo.toml

@@ -25,3 +25,4 @@ serde_derive = { version = "1.0", optional = true }
 
 [dev-dependencies]
 matches = "0.1.2"
+itertools = "0.14.0"

examples/sync_tcp_client.rs

@@ -26,7 +26,7 @@ fn main() {
     process::exit(code);
 }
 
-fn resolve(name: &str) -> Result<(), Box<Error>> {
+fn resolve(name: &str) -> Result<(), Box<dyn Error>> {
     let mut conn = TcpStream::connect("127.0.0.1:53")?;
     let mut builder = Builder::new_query(1, true);
     builder.add_question(name, false, QueryType::A, QueryClass::IN);
@@ -62,15 +62,12 @@ fn resolve(name: &str) -> Result<(), Box<Error>> {
     if pkt.header.response_code != ResponseCode::NoError {
         return Err(pkt.header.response_code.into());
     }
-    if pkt.answers.len() == 0 {
+    if pkt.answers.is_empty() {
         return Err("No records received".into());
     }
     for ans in pkt.answers {
-        match ans.data {
-            RData::A(Record(ip)) => {
-                println!("{}", ip);
-            }
-            _ => {} // ignore
+        if let RData::A(Record(ip)) = ans.data {
+            println!("{}", ip);
         }
     }
     Ok(())

examples/sync_udp_client.rs

@@ -25,7 +25,7 @@ fn main() {
     process::exit(code);
 }
 
-fn resolve(name: &str) -> Result<(), Box<Error>> {
+fn resolve(name: &str) -> Result<(), Box<dyn Error>> {
     let sock = UdpSocket::bind("127.0.0.1:0")?;
     sock.connect("127.0.0.1:53")?;
     let mut builder = Builder::new_query(1, true);
@@ -38,15 +38,12 @@ fn resolve(name: &str) -> Result<(), Box<Error>> {
     if pkt.header.response_code != ResponseCode::NoError {
         return Err(pkt.header.response_code.into());
     }
-    if pkt.answers.len() == 0 {
+    if pkt.answers.is_empty() {
         return Err("No records received".into());
     }
     for ans in pkt.answers {
-        match ans.data {
-            RData::A(Record(ip)) => {
-                println!("{}", ip);
-            }
-            _ => {} // ignore
+        if let RData::A(Record(ip)) = ans.data {
+            println!("{}", ip);
         }
     }
     Ok(())

rust-toolchain.toml

@@ -0,0 +1,2 @@
+[toolchain]
+channel = "1.75.0"

src/builder.rs

@@ -19,7 +19,7 @@ impl Builder {
     pub fn new_query(id: u16, recursion: bool) -> Builder {
         let mut buf = Vec::with_capacity(512);
         let head = Header {
-            id: id,
+            id,
             query: true,
             opcode: Opcode::StandardQuery,
             authoritative: false,
@@ -36,7 +36,7 @@ impl Builder {
         };
         buf.extend([0u8; 12].iter());
         head.write(&mut buf[..12]);
-        Builder { buf: buf }
+        Builder { buf }
     }
     /// Adds a question to the packet
     ///

src/enums.rs

@@ -167,10 +167,10 @@ impl From<u16> for Opcode {
         }
     }
 }
-impl Into<u16> for Opcode {
-    fn into(self) -> u16 {
+impl From<Opcode> for u16 {
+    fn from(value: Opcode) -> u16 {
         use self::Opcode::*;
-        match self {
+        match value {
             StandardQuery => 0,
             InverseQuery => 1,
             ServerStatusRequest => 2,
@@ -189,15 +189,15 @@ impl From<u8> for ResponseCode {
             3       => NameError,
             4       => NotImplemented,
             5       => Refused,
-            6...15  => Reserved(code),
+            6..=15  => Reserved(code),
             x       => panic!("Invalid response code {}", x),
         }
     }
 }
-impl Into<u8> for ResponseCode {
-    fn into(self) -> u8 {
+impl From<ResponseCode> for u8 {
+    fn from(value: ResponseCode) -> u8 {
         use self::ResponseCode::*;
-        match self {
+        match value {
             NoError         => 0,
             FormatError     => 1,
             ServerFailure   => 2,

src/lib.rs

@@ -19,6 +19,7 @@ extern crate byteorder;
 #[cfg(test)] #[macro_use] extern crate matches;
 #[macro_use(quick_error)] extern crate quick_error;
 #[cfg(feature = "with-serde")] #[macro_use] extern crate serde_derive;
+#[cfg(test)] extern crate itertools;
 
 mod enums;
 mod structs;

src/name.rs

@@ -55,7 +55,7 @@ impl<'a> Name<'a> {
                 // Set value for return_pos which is the pos in the original
                 // data buffer that should be used to return after validating
                 // the offsetted labels.
-                if let None = return_pos {
+                if return_pos.is_none() {
                     return_pos = Some(pos);
                 }
 
@@ -85,9 +85,9 @@ impl<'a> Name<'a> {
             byte = parse_data[pos];
         }
         if let Some(return_pos) = return_pos {
-            return Ok(Name {labels: &data[..return_pos+2], original: original});
+            Ok(Name {labels: &data[..return_pos+2], original })
         } else {
-            return Ok(Name {labels: &data[..pos+1], original: original });
+            Ok(Name {labels: &data[..pos+1], original })
         }
     }
     /// Number of bytes serialized name occupies
@@ -109,16 +109,16 @@ impl<'a> fmt::Display for Name<'a> {
                 let off = (BigEndian::read_u16(&data[pos..pos+2])
                            & !0b1100_0000_0000_0000) as usize;
                 if pos != 0 {
-                    try!(fmt.write_char('.'));
+                    fmt.write_char('.')?;
                 }
                 return fmt::Display::fmt(
                     &Name::scan(&original[off..], original).unwrap(), fmt)
             } else if byte & 0b1100_0000 == 0 {
                 if pos != 0 {
-                    try!(fmt.write_char('.'));
+                    fmt.write_char('.')?;
                 }
                 let end = pos + byte as usize + 1;
-                try!(fmt.write_str(from_utf8(&data[pos+1..end]).unwrap()));
+                fmt.write_str(from_utf8(&data[pos + 1..end]).unwrap())?;
                 pos = end;
                 continue;
             } else {