Skip to content

Conversation

@angelayu0530
Copy link
Collaborator

@angelayu0530 angelayu0530 commented Nov 6, 2025

-created a joincode generator ( will be replaced later)

  • wrote the endpoint to make a lobby with the creator in the lobby + returning the joincode
  • wrote lobby dto
Screenshot 2025-11-07 at 4 12 18 PM Screenshot 2025-11-09 at 12 02 29 PM

Copilot AI review requested due to automatic review settings November 6, 2025 23:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements lobby creation functionality for the duel/party system, enabling users to create lobbies with unique join codes that other players can use to join games.

Key Changes:

  • Introduced PartyCodeGenerator utility for generating 6-character alphanumeric join codes with collision detection
  • Added LobbyDto for structured lobby data transfer
  • Implemented the createParty endpoint in DuelController that creates a lobby and associates the creator as the first player

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
PartyCodeGenerator.java New utility class for generating unique random party codes with configurable retry logic
LobbyDto.java New DTO that maps Lobby entities to API response format with all relevant fields
DuelController.java Added createParty endpoint with authentication, duplicate lobby checks, and lobby/player creation logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Overall Project 63.05% -0.81% 🍏
Files changed 6.75%

File Coverage
DuelController.java 13.43% -56.72%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Overall Project 62.66% -0.8% 🍏
Files changed 6.83%

File Coverage
DuelController.java 13.43% -56.72%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

@angelayu0530 angelayu0530 requested a review from Copilot November 6, 2025 23:54
Repository owner deleted a comment from Copilot AI Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Overall Project 63.44% -0.81% 🍏
Files changed 6.75%

File Coverage
DuelController.java 13.24% -57.35%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

Arshadul-Monir
Arshadul-Monir previously approved these changes Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Overall Project 63.06% -0.78% 🍏
Files changed 5.16%

File Coverage
DuelController.java 11.72% -57.03%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Overall Project 63.16% -0.63% 🍏
Files changed 6.35%

File Coverage
DuelController.java 12.82% -52.99%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Overall Project 63.23% -0.63% 🍏
Files changed 6.35%

File Coverage
DuelController.java 12.82% -52.99%
LobbyDto.java 0%
PartyCodeGenerator.java 0%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Overall Project 63.77% -0.14% 🍏
Files changed 78.57%

File Coverage
PartyCodeGenerator.java 90.63% -9.38% 🍏
DuelController.java 74.36% 🍏
LobbyDto.java 0%

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Overall Project 63.73% -0.13% 🍏
Files changed 74.47%

File Coverage
DuelController.java 74.36% 🍏
LobbyDto.java 0%

angelayu0530 and others added 8 commits November 9, 2025 19:11
Update src/main/java/com/patina/codebloom/api/duel/DuelController.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

nits
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tahminator tahminator merged commit 12d3686 into main Nov 10, 2025
3 of 4 checks passed
@tahminator tahminator deleted the create-party branch November 10, 2025 00:12
@github-actions
Copy link
Contributor

Overall Project 64.28% -0.13% 🍏
Files changed 74.47%

File Coverage
DuelController.java 74.36% 🍏
LobbyDto.java 0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants