Adds include support to match tests before calling run().#8
Adds include support to match tests before calling run().#8elsigh wants to merge 1 commit intotagview:masterfrom
Conversation
There was a problem hiding this comment.
Ouch, these variable-variables name looks so creepy. I know it is a bit more verbose, but wouldn't you mind to use change it to something like:
switch($configuration) {
case 'include':
$include_files = $value;
break;
case 'include_report':
$include_report = $value
break
}There was a problem hiding this comment.
Done. Yeah, I felt particularly PHP-y using the $$ ;0 This is nicer.
|
Looks great IMO! I just need to give a try before merging. |
|
As a side note, it would be cool if there were unit tests for the project, just because manual testing is kind of a pain. |
|
Fixes #5 |
|
cool, thanks! I put up the inclusion of the GoTestEngine as well. On Wed, Apr 29, 2015 at 6:45 PM, Rodrigo Navarro notifications@github.com
|
|
any chance you want to merge this still? I can keep using my own repo, but I like using a single one ;) |
Updated PR because $$ means I need to name the variable $include not $include_regex. Tested that it's working.