Use ESLint installed as project dependency before looking for global installation of ESLint#23
Open
ydsood wants to merge 1 commit intotagview:masterfrom
Open
Use ESLint installed as project dependency before looking for global installation of ESLint#23ydsood wants to merge 1 commit intotagview:masterfrom
ydsood wants to merge 1 commit intotagview:masterfrom
Conversation
ArcanistESLinter should look for ESlint locally installed in project before looking for global installation of ESLint. If both are missing it should throw an exception.
ydsood
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
ArcanistESLinter should look for ESlint locally installed in project before looking for global installation of ESLint. If both are missing it should throw an exception.
This allows for adding ESLint as a dev dependency to projects and also allows collaborators to start using the repository without having to install additional software on their local machines.