user prompting to select a variable name for multiple matches#39
Merged
kpgriesser merged 1 commit intoiconsolefrom Jan 27, 2026
Merged
user prompting to select a variable name for multiple matches#39kpgriesser merged 1 commit intoiconsolefrom
kpgriesser merged 1 commit intoiconsolefrom
Conversation
…match is found. This can be disabled using "confirm false" in the console which will revert to the prototype functionality of simply selecting the first match. This should be removed by ensuring the object map has unique variable names ( and not use std::multimap )... presumably
|
CLANG-FORMAT TEST - FAILED (on last commit): |
kpgriesser
commented
Jan 27, 2026
| std::string SimpleDebugger::replayFilePath = "sst-console.in"; | ||
| bool SimpleDebugger::enLogging = false; | ||
| bool SimpleDebugger::confirm = true; | ||
| bool SimpleDebugger::confirm_ = true; |
Collaborator
Author
There was a problem hiding this comment.
I think we should have members using the '_' suffix convention. I added it here as I thought I had a name conflict (which I didn't) but left it in anyway
donofrio
reviewed
Jan 27, 2026
donofrio
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original prototype for
ObjectMap::findVariabledoes not handle the case when multiple matches are found. With this change, the user (by default) will be prompted. This can be disabled using "confirm false" in the console which will revert to the prototype functionality of simply selecting the first match.This edit should be removed by ensuring the object map has unique variable names ( and not use std::multimap )... presumably. Additionally, the
confirminformation will only be passed into thecd_cmdfunction so all other calls tofindVariablemay result in prompting the user. This is by design, as I am hoping we can uniquely the variable names and avoid the use ofstd::multimapaltogether.Duplicate names can occur at the same level of hierarchy when using sub-components. The one example I know if is creating a variable in a subcomponent name that has the same name as the subcomponent slot it populates. See example in tactcomplabs/sst-ext-tests#99