Skip to content

Conversation

@kou029w
Copy link

@kou029w kou029w commented May 28, 2024

fixed #151

Removed utils.condensePath and updated all references to use the enhanced utils.which, which now replaces the home directory with ~. Updated and added tests to ensure functionality.

fixed tabrindle#151

Removed `utils.condensePath` and updated all references to use the enhanced `utils.which`, which now replaces the home directory with ~. Updated and added tests to ensure functionality.
@gengjiawen
Copy link
Collaborator

eplaces the home directory with ~

this is really a bad idea the way I see it. Can you revert this part.

@kou029w
Copy link
Author

kou029w commented Jul 19, 2024

Thank you for your feedback. I understand your concern about replacing the home directory with ~. Could you please elaborate on the issues you foresee with this approach?

My initial reasoning was to ensure consistency across various environments and to obscure user-specific paths. However, I am open to reverting this change if there are significant drawbacks.

Looking forward to your detailed input so we can find the best solution.

@kou029w
Copy link
Author

kou029w commented Nov 14, 2025

@gengjiawen
Would adding an option to disable the ~ substitution address your concern?
If the main issue is the loss of the absolute home path, I can make this behavior opt-in or opt-out.
Let me know whether configurability would resolve the problem, or if you see deeper issues with integrating condensePath into which.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

utils.condensePath isn't used everywhere utils.which is

2 participants