Bump cookstyle from 3.0.0 to 6.14.7

[dependabot-preview]

Bumps cookstyle from 3.0.0 to 6.14.7.

Release notes

Sourced from cookstyle's releases.

Cookstyle 6.0.19

RuboCop 0.80.1 Engine

The RuboCop engine that powers Cookstyle has been updated from 0.75.1 to 0.80.1. This new engine includes hundreds of bug fixes and new features that will allow us to write even more advanced Cookstyle rules in the future. This release also renames many of RuboCop's built-in cops so if you have a complex rubocop.yml file that disables or enables rules, you may see warnings instructing you to update your config.

ChefDeprecation Cops At Warning Level

All ChefDeprecation department cops now alert at Warning level instead of Refactor. This means that these cops will now result in Cookstyle exiting with a -1 exit code, which will cause failures in CI tests. ChefDeprecation cops are important to resolve and we believe this will the use of the latest Chef Infra coding standards.

9 New Cops

ChefDeprecations/DeprecatedWindowsVersionCheck

The ChefDeprecations/DeprecatedWindowsVersionCheck cop detects cookbooks that use the legacy older_than_win_2012_or_8? helper method. Chef Infra Client no longer supports Windows releases before 8 / 2012. Those releases are end of life so this check can be removed from cookbooks.

ChefDeprecations/ChefWindowsPlatformHelper

The ChefDeprecations/ChefWindowsPlatformHelper cop detects cookbooks that use the deprecated helper Chef::Platform.windows? to see if a system is running on Windows instead of using platform?('windows') or the new windows? helper.

ChefDeprecations/LogResourceNotifications

The ChefDeprecations/LogResourceNotifications cop detects notifications in the log resource. Beginning in Chef Infra Client 16, the log resource will no longer trigger an update, so these notifications will never fire. This will create problems for users who concatenate notifications from multiple resources into a single log resource so that those notifications only fire a single time. For example, many resource updates in your cookbook may require a service to restart, but a user may only want to trigger that service to restart once. Chef Infra Client 15.8 and later ships with a notify_group resource specifically for aggregating notifications in this way. This resource should be used instead.

Aggregating Notifications with a log resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :write, 'log[Aggregate notifications using a single log resource]', :immediately
end
log 'Aggregate notifications using a single log resource' do
notifies :restart, 'service[foo]', :delayed
end

Aggregating Notifications with a notify_group resource

template '/etc/foo' do
  source 'bar.erb'
  notifies :run, 'notify_group[Aggregate notifications using a single notify_group resource]', :immediately
end
notify_group 'Aggregate notifications using a single notify_group resource' do
notifies :restart, 'service[foo]', :delayed
end

ChefDeprecations/ResourceWithoutNameOrProvides

Changelog

Sourced from cookstyle's changelog.

v6.14.7 (2020-07-30)

Merged Pull Requests

• Fix matcher name to match what we're doing #691 (tas50)
• Multiple spelling corrections including a cop name #697 (tas50)
• Update dead links #696 (dg42xyz)
• Cleanup leftover config from rubocop-chef project #698 (tas50)
• Fix a few incorrect StyleGuide links #699 (tas50)
• Fix target_chef_version support in the new Rubocop 0.88+ format of cops #700 (tas50)
• Add 2 new cops for macos_userdefaults changes in 16.3 #701 (tas50)
• Update ChefStyle/FileMode to support files_mode as well #702 (tas50)

v6.13.3 (2020-07-17)

Merged Pull Requests

• Add ChefCorrectness/InvalidDefaultAction cop #685 (tas50)
• Add new ChefModernize/CronDFileOrTemplate cop #686 (tas50)
• Add ChefRedundantCode/DoubleCompileTime cop #687 (tas50)
• Add ChefCorrectness/SupportsMustBeFloat #689 (tas50)
• Add release notes for 6.13 #690 (tas50)
• Add ChefModernize/ActionMethodInResource cop #688 (tas50)

v6.12.6 (2020-07-15)

Merged Pull Requests

• Detect additional ways to shellout to apt-get update #670 (tas50)
• Add new ChefDeprecations/ChefDKGenerators cop #671 (tas50)
• Add ChefDeprecations/ChefHandlerRecipe cop #678 (tas50)
• Add ChefDeprecations/UseAutomaticResourceName cop #680 (tas50)
• Bump RuboCop to 0.88 #683 (tas50)
• Set frozen string literals to true in all files #682 (tas50)
• Copy over profiling support from RuboCop #681 (tas50)

v6.11.4 (2020-07-09)

Merged Pull Requests

• Update RuboCop engine to 0.87.1 #664 (tas50)
• Expand NodeInitPackage to catch more bad systemd tests #665 (tas50)
• Add new ChefStyle/IncludeRecipeWithParentheses #667 (tas50)
• Add new cop ChefModernize/ConditionalUsingTest #666 (tas50)
• Expand IncorrectLibraryInjection to detect more types of injection #668 (tas50)

v6.10.2 (2020-07-07)

Merged Pull Requests

• Add cookstyle cop to detect using .to_s on ohai attribute #659 (tas50)
• Add new ChefRedundantCode/MultiplePlatformChecks cop #660 (tas50)
• Monkeypatch the Migration/DepartmentName cop to suggest cookstyle #661 (tas50)
• Add ChefSharing/IncludeResourceExamples #662 (tas50)

Commits

• 3b49259 Bump version to 6.14.7 by Chef Expeditor
• ba6cfd0 Merge pull request #702 from chef/files_mode
• 13d8a86 Update ChefStyle/FileMode to support files_mode as well
• 62845d6 Bump version to 6.14.6 by Chef Expeditor
• 09f4ff3 Merge pull request #701 from chef/163_cops
• 10d6223 Test for a invalid value not in the list
• cbbf38b Add 2 new cops for macos_userdefaults changes in 16.3
• 49725c9 Bump version to 6.14.5 by Chef Expeditor
• 225073c Merge pull request #700 from chef/fix_monkeypatch
• bfa2be1 Fix target_chef_version support in the new Rubocop 0.88+ format of cops
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

• Update frequency (including time of day and day of week)
• Pull request limits (per update run and/or open at any time)
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[dependabot-preview]

Superseded by #189.