Skip to content

Remove bundler dependency#50

Open
koenpunt wants to merge 2 commits intotablexi:masterfrom
koenpunt:remove-bundler-dependency
Open

Remove bundler dependency#50
koenpunt wants to merge 2 commits intotablexi:masterfrom
koenpunt:remove-bundler-dependency

Conversation

@koenpunt
Copy link
Copy Markdown

This change makes using bundler optional

More on this here: https://github.com/capistrano/bundler#usage

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this

@ernetas
Copy link
Copy Markdown

ernetas commented Jan 29, 2016

+1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you need hook rvm (if you use one):

set :rvm_map_bins, fetch(:rvm_map_bins, []).push('unicorn')

or if rbenv:

set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn))

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rbenv for that matter, but people who will use those implementations, will probably know the implication of the usage.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I didn't knew... I needed to read how sidekiq capistrano tasks was implemented.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn))

is incorrect, or at least cumbersome.

this is more concise:

set :rbenv_map_bins, fetch(:rbenv_map_bins, []).push('unicorn')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it work's: set :rvm_map_bins, fetch(:rvm_map_bins).to_a.concat(%w(unicorn)) or set :rbenv_map_bins, fetch(:rbenv_map_bins).to_a.concat(%w(unicorn)) or for : chruby_map_bins or for bundle_bins

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or at least cumbersome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants